Skip to content

Conversation

@siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Apr 28, 2022

I missed a boundary condition in #78 for the left side, added it now :)

Now, If there isn't enough space on the left, it will first try to switch alignment before trying to brute force it

Before After
image image

@changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2022

🦋 Changeset detected

Latest commit: e5aaf68

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/behaviors Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@khiga8 khiga8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh nice catch!

@siddharthkp siddharthkp merged commit c143ea2 into main Apr 29, 2022
@siddharthkp siddharthkp deleted the siddharthkp/fix-left-boundary-collision branch April 29, 2022 10:58
@primer-css primer-css mentioned this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants