-
Notifications
You must be signed in to change notification settings - Fork 63
Rails 6 minor and patch #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mrsweaters Thanks! Thanks! |
Pull Request Test Coverage Report for Build 165
💛 - Coveralls |
|
I updated the appraisal but now I'm getting an issue looking for a manifest file: Failure/Error: //= link terms_manifest.js
ActionView::Template::Error:
couldn't find file 'terms_manifest.js'I see a policy_manager_manifest.js but no terms_manifest.js. |
@mrsweaters - I pulled the repo down and couldn't find any other reference besides that failure in Thanks for the contribution! 🥇
Super weird, my PR #47 didn't fail on that issue. Perhaps it needs to just rerun & it's generated somewhere? https://travis-ci.org/prey/gdpr_rails/builds/638550797 |
|
@michelson @masonhensly Oh interesting! Yeah maybe it is cached in Travis somewhere. |
|
@mrsweaters - would you be able to make a one line change to the MR so that Travis is retriggered? 🤞 everything would be green then. If you're too busy, do you mind me forking your branch and submitting it as a new MR to get it to green? Thanks again |
|
yeah that didn't seem to help, feel free to have at it. |
This will allow us to update Rails to the recent security-patched versions of Rails.
Closes: #44