Skip to content

fix: remove into_diagnostic for proper error messages #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2025
Merged

fix: remove into_diagnostic for proper error messages #415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions crates/pixi-build-rattler-build/src/protocol.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,20 +273,16 @@ impl Protocol for RattlerBuildBackend {
&self.source_dir,
&self.recipe_source.path,
&selector_config_for_variants,
)
.into_diagnostic()?
)?
.extend_with_input_variants(&params.variant_configuration.unwrap_or_default());

// Find all outputs from the recipe
let output_nodes = find_outputs_from_src(self.recipe_source.clone())?;
let discovered_outputs = variant_config
.variant_config
.find_variants(
&output_nodes,
self.recipe_source.clone(),
&selector_config_for_variants,
)
.into_diagnostic()?;
let discovered_outputs = variant_config.variant_config.find_variants(
&output_nodes,
self.recipe_source.clone(),
&selector_config_for_variants,
)?;

// Construct a mapping that for packages that we want from source.
//
Expand Down
Loading