Skip to content

feat: support variant files #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2025
Merged

feat: support variant files #400

merged 2 commits into from
Oct 15, 2025

Conversation

Hofer-Julian
Copy link
Contributor

@Hofer-Julian Hofer-Julian commented Oct 6, 2025 •
edited
Loading

  • Add support for variant files to the backend
  • Order (later means higher priority)
    • Default variants
    • Local variants.yaml for pixi-build-rattler-build
    • Variant files from the backend
    • Inline variants from the backend
  • There are a couple of tests to verify this behavior, others are in test: variant files pixi-build-testsuite#70

Also updated rattler and Pixi

AI disclosure

  • Tests were mostly generated by codex. I reviewed and adapted them
  • I also used codex for minor, repetitive changes

This was referenced Oct 6, 2025
Merged
Merged
Merged
nichmor
nichmor reviewed Oct 10, 2025
View reviewed changes
Hofer-Julian
Hofer-Julian commented Oct 14, 2025
View reviewed changes
@Hofer-Julian Hofer-Julian marked this pull request as ready for review October 14, 2025 09:25
@Hofer-Julian Hofer-Julian force-pushed the feat/variant-files branch 3 times, most recently from 9aa377a to afffe7c Compare October 14, 2025 12:50
ruben-arts
ruben-arts approved these changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@Hofer-Julian
feat: support variant files
1e33582 
Adapt error messages

Adapt to rattler-build breaking changes

Update rattler-build

Add implementation and tests

Update patch

Update lock file

Update dependencies

Update pixi.lock

Update cargo.lock

Update pixi.lock

Address comments

Update lockfile

Hook up zip_keys

Only consider variant files if the list isn't empty

Update lock file

Update lock

Reverse the order of the variant files so that the first file has the highest priority.
@Hofer-Julian
Add ?
46810b3
@Hofer-Julian Hofer-Julian merged commit 4fd72b1 into prefix-dev:main Oct 15, 2025
14 checks passed
@Hofer-Julian Hofer-Julian deleted the feat/variant-files branch October 15, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baszalmstra baszalmstra baszalmstra left review comments

@nichmor nichmor nichmor left review comments

@ruben-arts ruben-arts ruben-arts approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Hofer-Julian @baszalmstra @ruben-arts @nichmor