-
Notifications
You must be signed in to change notification settings - Fork 19
chore(ci): build channel from artifacts #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(ci): build channel from artifacts #395
Conversation
3eea16f
to
e06541e
Compare
scripts/activate.sh
Outdated
# export CARGO_TARGET_X86_64_UNKNOWN_LINUX_GNU_LINKER="clang" | ||
# export CARGO_TARGET_X86_64_UNKNOWN_LINUX_GNU_RUSTFLAGS="-C link-arg=-fuse-ld=$CONDA_PREFIX/bin/mold" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there are reason to disable this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build of pixi-build-ros
fails with mold, didn't investigated reasons though. I'll return back to this after CI will be green.
e06541e
to
877a8bd
Compare
5353731
to
93a47a9
Compare
8c96417
to
9f948a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
files: | ||
exclude: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Schema is unhappy with this.
- If the schema's wrong -> fix the schema
- Otherwise fix this
|
||
build: | ||
script: | ||
- cargo build --profile ci --locked --bins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add the following to avoid rebuilds from scratch:
export CARGO_TARGET_DIR=${{ SRC_DIR }}/../../target-cache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be invalidated between builds of recipe.
I found a regression in compilation time. It seems that |
89f1dcf
to
698cd97
Compare
Problem
In the future we will have backends written in different languages which would require different dependencies. Current approach can't fulfill this, since we expect all binaries to be self-contained. It works for backends written in rust, but don't work for backends written in python for example.
Solution
Instead we can build conda packages from backends and pack them into temporary channel that will be stored in artifacts. This way in the pixi build testsuite we can augment manifests that we test with absolute path to this channel and therefore obtain latest backends required for testing.