Skip to content

Follow up fixes #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2023
Merged

Follow up fixes #283

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c0951c
changeset
JoviDeCroock Feb 25, 2023
dfac25a
Update util.js
JoviDeCroock Feb 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fluffy-poets-happen.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'preact-render-to-string': patch
---

Follow up fixes to #278
7 changes: 4 additions & 3 deletions src/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,15 @@ export function styleObjToCss(s) {
(JS_TO_CSS[prop] = prop.replace(CSS_REGEX, '-$1').toLowerCase());

let suffix = ';';
if (SUFFIX_CACHE[name]) {
let isNumber = typeof val === 'number';
if (isNumber && SUFFIX_CACHE[name]) {
suffix = 'px';
Copy link
Member

@andrewiggins andrewiggins Feb 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more semicolon here, I think :)

} else if (
typeof val === 'number' &&
isNumber &&
IS_NON_DIMENSIONAL.test(prop.toLowerCase()) === false
) {
SUFFIX_CACHE[name] = true;
suffix = 'px';
suffix = 'px;';
}
str = str + name + ':' + val + suffix;
}
Expand Down