Skip to content

Conversation

@idobetesh
Copy link
Collaborator

No description provided.

@request-info
Copy link

request-info bot commented Jul 6, 2022

Thanks for opening this PR! We would appreciate it if you could provide us with more info about your PR 🙏

@idobetesh
Copy link
Collaborator Author

Add pre-commit configuration with Husky.
From now on, all commits will trigger Husky and check our code against .prettierrc.json.

},
"node_modules/@types/minimatch": {
"version": "3.0.5",
"resolved": "https://art-bobcat.autodesk.com:443/artifactory/api/npm/autodesk-npm-virtual/@types/minimatch/-/minimatch-3.0.5.tgz",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like dependencies were install with art-bobcat registry which is not available outside of Autodesk's network. Can you please revert changes to package.lock file and try to reinstall dependencies (if you have any new dependencies) with the new npmrc file (added in a previous PR) which specifies the global npm registry.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in this PR ✨

@idobetesh idobetesh closed this Jul 7, 2022
@idobetesh idobetesh deleted the Add_pre_commit_configuration_with_Husky branch July 7, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants