Skip to content

Check if abort future is completed before completing it #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Check if abort future is completed before completing it #100

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b3ae8b
Check if abort future is completed before completing it
mugikhan Jun 19, 2024
6b8872e
Bump powersync version
mugikhan Jun 19, 2024
8c9c65c
Merge branch 'master' into fix/prevent-completing-futures-twice
mugikhan Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/powersync/lib/src/abort_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,18 @@ class AbortController {
/// Abort, and wait until aborting is complete.
Future<void> abort() async {
aborted = true;
_abortRequested.complete();
if (!_abortRequested.isCompleted) {
_abortRequested.complete();
}

await _abortCompleter.future;
}

/// Signal that an abort has completed.
void completeAbort() {
_abortCompleter.complete();
if (!_abortCompleter.isCompleted) {
_abortCompleter.complete();
}
}

/// Signal that an abort has failed.
Expand Down