-
Notifications
You must be signed in to change notification settings - Fork 59
update: added client parameters to PowerSyncCredentials which are available in sync rules. #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…to `/sync/stream` request.
packages/common/src/client/sync/stream/AbstractStreamingSyncImplementation.ts
Outdated
Show resolved
Hide resolved
rkistner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we instead pass the parameters when calling connect()?
The credentials are fetched at non-deterministic times, which can make it difficult to update the parameters.
Sounds good |
7f4f84c to
23d77f8
Compare
|
@rkistner, I've updated the PR to use |
packages/common/src/client/sync/stream/AbstractStreamingSyncImplementation.ts
Outdated
Show resolved
Hide resolved
…ersync-js into feature/user-parameters


This PR introduces the ability to pass parameters from a client SDK to the sync rules. The idea is to specify parameters to the PowerSync
connectmethod's options . Backend changes to support this are available here.Parameters are available in the sync rules under
user_parameters(alongside the already supportedtoken_parameters).For example:
Testing
Verified values pull through via self-host project.