Support cross-site cookies in sample cookie config #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the `SameSite` option to `Strict` for cookies created during a cross-site authentication process like OAuth2 can easily cause failures which will be somewhat opaque to diagnose and fix. Provide sane defaults instead for this sample cookie configuration that are more closely aligned to Phoenix's default cookie configuration. See: - https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#samesitesamesite-value - https://github.com/phoenixframework/phoenix/blob/v1.7.18/installer/templates/phx_web/endpoint.ex#L11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💁 Setting the
SameSiteoption toStrictfor cookies created during a cross-site authentication process like OAuth2 can easily cause failures which will be somewhat opaque to diagnose and fix. This change to the sample cookie configuration provides a sane default forSameSitewhich is more closely aligned to Phoenix's default cookie configuration.See: