Skip to content

Change minimum node version required to v12 #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Change minimum node version required to v12 #671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b27a159
Upgrade node version in CI to v12.x
webholik Feb 7, 2023
f1d1d56
Fix test checking for node version
webholik Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
- name: Setup Node JS
uses: actions/setup-node@v1
with:
node-version: '8.x'
node-version: '12.x'
- name: Install system dependencies
run: npm run cirequirements
- name: Install package dependencies
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,6 @@
"watchify": "3.11.1"
},
"engines": {
"node": ">=6"
"node": ">=12"
}
}
2 changes: 1 addition & 1 deletion test/system/repository.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ describe('project repository', function () {
expect(json).to.have.property('repository');

expect(json).to.have.property('engines');
expect(json.engines).to.eql({ node: '>=6' });
expect(json.engines).to.eql({ node: '>=12' });
});

it('must have a valid version string in form of <major>.<minor>.<revision>', function () {
Expand Down