Fix pcn k8s #100
Merged
Fix pcn k8s #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation code for the list was not testing all the elements of the list,
it instead was testing the list as a container. Due to this complex commands
issued with a rest client were failing, for instance:
curl -L -X POST --data '{"name":"hw0","ports":[{"name":"pippo"}]}' \
"http://localhost:9000/polycube/v1/helloworld/hw0/"
curl -L -X POST --data \
'[{"name":"toveth1", "peer":"veth1"}, {"name":"toveth2", "peer":"veth2"}]' \
"http://localhost:9000/polycube/v1/helloworld/hw0/ports/
This commit implements a new logic that tests all the elements in a list, also
a new logic fill the keys in json body of a list request is added as well.
This failure was unnoticed because polycubectl does not allow to perform such
complex operations in a single command.
Fixes: d8d280c ("Added new REST API and validation code")
Fixes: 795ce96 ("move help generation from services to daemon")
Signed-off-by: Mauricio Vasquez B <[email protected]>
after 18becf4 ("polycubed: fix list validation") a parameter that can only be set at initialization time must be "config true" and use the init-only-config extension of polycube. Fixes: ab259a9 ("Ported k8sfilter") Signed-off-by: Mauricio Vasquez B <[email protected]>
Before 09356c4c033 ("services: remove generate_code and generate_code_vector")
the k8switch was created with a stub program and then reloaded with the initial
configuration. That approach is far from optimal as the code is immediately
reloaded, then 09356c4c033 changed that to created the cube without any eBPF
program and then add it with the initial configuration.
However, the call to reload_program was still there, it fails because the
stub is not present anymore. This commits fix that by calling add_program
when the cube is created.
Fixes: e09356c ("services: remove generate_code and generate_code_vector")
Signed-off-by: Mauricio Vasquez B <[email protected]>
frisso
approved these changes
Apr 5, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pcn-k8s was broken in few places: