UI test target support #975
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swift Testing is not compatible with UITest targets at the moment, but unfortunately `#if canImport` still returns `true`, making it difficult to ship libraries that provide tools for both `Testing` and `XCTest`, like the `assertSnapshot`. The previous workarounds we relied on have stopped working, and so we need a new approach. In this PR we have introduced a forwards-compatible `SnapshotUITesting` module that does not rely on any imports of `Testing` internally. We can then introduce Swift Testing support in the `SnapshotTesting` module, instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Snapshot Testing added Swift Testing support, it unfortunately broke the ability to use the library in UI test targets, which are incompatible with Swift Testing, and Apple does not appear provide the tools to statically bracket code in UI test targets.
To alleviate the issue, this PR divides Snapshot Testing functionality between a few modules so that a new
UISnapshotTestingtarget can be introduced and depended on instead.