Escape carriage returns explicitly #772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Either Xcode or SwiftSyntax is stripping the carriage return out of the snapshot, but either way we should probably explicitly escape them for visibility. Fixes #771.
|
Testing this branch out on my failing test now. |
mbrandonw
approved these changes
Sep 13, 2023
|
Can confirm this fixes the issue for my specific test failure. 🎉 |
Member
Author
|
@lukeredpath Great! Will merge when green and cut a patch release in the next few days after the dust settles a bit more. |
isismsilva
referenced
this pull request
in powerhome/playbook-swift
Oct 3, 2023
#166) [](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [pointfreeco/swift-snapshot-testing](https://togithub.com/pointfreeco/swift-snapshot-testing) | minor | `from: "1.13.0"` -> `from: "1.14.0"` | --- ### Release Notes <details> <summary>pointfreeco/swift-snapshot-testing (pointfreeco/swift-snapshot-testing)</summary> ### [`v1.14.0`](https://togithub.com/pointfreeco/swift-snapshot-testing/releases/tag/1.14.0) [Compare Source](https://togithub.com/pointfreeco/swift-snapshot-testing/compare/1.13.0...1.14.0) #### What's Changed - Added: Support for inline snapshot API migrations ([https://github.com/pointfreeco/swift-snapshot-testing/pull/779](https://togithub.com/pointfreeco/swift-snapshot-testing/pull/779)) - Updated: Pinned SwiftSyntax to 509.0.0 ([https://github.com/pointfreeco/swift-snapshot-testing/pull/774](https://togithub.com/pointfreeco/swift-snapshot-testing/pull/774)). - Fixed: Escape carriage returns explicitly in inline snapshots ([https://github.com/pointfreeco/swift-snapshot-testing/pull/772](https://togithub.com/pointfreeco/swift-snapshot-testing/pull/772)). - Infrastructure: CONTRIBUTING.md fixes (thanks [@​soo941226](https://togithub.com/soo941226), [https://github.com/pointfreeco/swift-snapshot-testing/pull/773](https://togithub.com/pointfreeco/swift-snapshot-testing/pull/773)). #### New Contributors - [@​soo941226](https://togithub.com/soo941226) made their first contribution in [https://github.com/pointfreeco/swift-snapshot-testing/pull/773](https://togithub.com/pointfreeco/swift-snapshot-testing/pull/773) **Full Changelog**: pointfreeco/swift-snapshot-testing@1.13.0...1.14.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/powerhome/PlaybookSwift). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
](https://renovatebot.com){kind=link}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Either Xcode or SwiftSyntax is stripping the carriage return out of the snapshot, but either way we should probably explicitly escape them for visibility.
Fixes #771.