Support for xcode 15b1 #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finestructure
commented
Jun 6, 2023
| #if os(macOS) | ||
| import AppKit | ||
| import Cocoa | ||
| import QuartzCore |
Contributor
Author
There was a problem hiding this comment.
These are warnings only with Xcode 15. Bit odd that they show up given that Cocoa is there. Perhaps a b1 issue only?
finestructure
commented
Jun 6, 2023
| /// A snapshot strategy for comparing bezier paths based on pixel equality. | ||
| /// | ||
| /// - Parameter numberFormatter: The number formatter used for formatting points. | ||
| @available(macOS 11.0, *) |
Contributor
Author
There was a problem hiding this comment.
These two availability attributes are the only ones truly required to fix the build with Xcode 15.
finestructure
commented
Jun 6, 2023
Contributor
Author
There was a problem hiding this comment.
This is a baffling diff, not sure why that comes out so differently - nor how that passes with Xcode 13.4.1 after the change.
stephencelis
approved these changes
Jun 15, 2023
Member
stephencelis
left a comment
stephencelis
left a comment
There was a problem hiding this comment.
Thanks! Some of the artifacts are puzzling but will investigate outside of merging.
isismsilva
referenced
this pull request
in powerhome/playbook-swift
Aug 17, 2023
#116) [](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [pointfreeco/swift-snapshot-testing](https://togithub.com/pointfreeco/swift-snapshot-testing) | patch | `from: "1.11.0"` -> `from: "1.11.1"` | --- ### Release Notes <details> <summary>pointfreeco/swift-snapshot-testing (pointfreeco/swift-snapshot-testing)</summary> ### [`v1.11.1`](https://togithub.com/pointfreeco/swift-snapshot-testing/releases/tag/1.11.1) [Compare Source](https://togithub.com/pointfreeco/swift-snapshot-testing/compare/1.11.0...1.11.1) #### What's Changed - Fixed: Xcode 15 support (thanks [@​finestructure](https://togithub.com/finestructure), [https://github.com/pointfreeco/swift-snapshot-testing/pull/737](https://togithub.com/pointfreeco/swift-snapshot-testing/pull/737)). - Infrastructure: Add PreviewSnapshots to README "Plug-ins" (thanks [@​jflan-dd](https://togithub.com/jflan-dd), [https://github.com/pointfreeco/swift-snapshot-testing/pull/696](https://togithub.com/pointfreeco/swift-snapshot-testing/pull/696)) **Full Changelog**: pointfreeco/swift-snapshot-testing@1.11.0...1.11.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/powerhome/PlaybookSwift). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNDQuMiIsInVwZGF0ZWRJblZlciI6IjM1LjE0NC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the project build on macOS 13 Ventura with Xcode 15.0b1. Tests also pass (same OS version) with Xcode 14.3.1, which seems a bit odd since there were snapshot diffs. I didn't go back and test
mainwith Xcode 14.3.1 but I believe it would meanmainwouldn't pass with Xcode 13.4.1 on macOS 13 Ventura 🤷♂️Not sure if this is useful at this stage but since we use snapshot testing in SPI-Server and it failed the build due to these errors, I thought I'd start the discussion :)