Add support for SwiftSyntax 602. #1023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
If approved/merged/released/etc I'd be happy to also take a look at making the same changes in swift-macro-testing. |
Member
|
@noremac I tried to push a commit to your branch but don't have access. Can you either revert the Package.resolved changes so that we can merge a green CI build? I can bump CI in a separate PR later on. |
Member
|
Going to merge for now and fix CI in another PR, since this is blocking other downstream updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the swift syntax requirement to allow up through version 602. I've updated the resolved file, rebuilt, and confirmed that no code changes are necessary and no new deprecation warnings are introduced.
I did see a few test failures, shown below, but they were pre-existing for me and I believe they are likely because I am on Tahoe.