Skip to content

Update Docker and pnpm fetch to be more aligned and link to each other #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

segevfiner
Copy link

No description provided.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Aug 21, 2024

@segevfiner is attempting to deploy a commit to the pnpm Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Author

@segevfiner segevfiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added a more complex Dockerfile example that combines all the techniques.

@segevfiner
Copy link
Author

Also it is likely a user will want a .dockerignore/Dockerfile.dockerignore, e.g.

**/node_modules
**/dist

Though there are likely additional patterns he might want. We can add that to the docs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant