Skip to content

Conversation

robertoffmoura
Copy link

Hi,
I'm proposing a fix to an edge case where conversion from matplotlib to plotly would break when converting a "lines+markers" plot with a legend. The issue happens because go.layout.Shape is not expecting "symbol" or "size" properties. My proposed fix is to ignore those two properties for "lines" type legend shapes. Please let me know if another fix would be more appropriate.

Thanks

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • For a new feature, I have added documentation examples in an existing or
    new tutorial notebook (please see the doc checklist as well).
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.
  • For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).

@gvwilson gvwilson self-requested a review June 20, 2025 13:41
@gvwilson gvwilson self-assigned this Jun 20, 2025
@gvwilson gvwilson added P1 needed for current cycle community community contribution fix fixes something broken labels Jun 20, 2025
@robertoffmoura robertoffmoura force-pushed the rm/fix-line+markers-plot branch from 047774a to bf91f93 Compare August 12, 2025 09:07
@robertoffmoura robertoffmoura force-pushed the rm/fix-line+markers-plot branch from bf91f93 to da37239 Compare August 12, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution fix fixes something broken P1 needed for current cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants