Skip to content

Conversation

MarcoGorelli
Copy link
Contributor

This comment wasn't totally accurate, sorry

The flag indicates whether the object needs converting to PyArrow, but this doesn't necessarily happen via the interchange protocol. For DuckDB and Ibis, we just call their native "to arrow" methods, the interchange protocol is just the last fallback

In any case, I think that how exactly the conversion happens is an implementation detail, what Plotly sees is just that a conversion to PyArrow happens:

args["data_frame"] = nw.from_native(
    args["data_frame"].to_arrow(), eager_only=True
)

Copy link
Member

@LiamConnors LiamConnors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MarcoGorelli !

@LiamConnors LiamConnors merged commit 817fef7 into plotly:master Nov 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants