Skip to content

set line_group in wide mode #2599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2020
Merged

set line_group in wide mode #2599

merged 1 commit into from
Jun 25, 2020

Conversation

nicolaskruchten
Copy link
Contributor

closes #2583

Code PR

  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.

@nicolaskruchten nicolaskruchten added this to the 4.8.2 milestone Jun 25, 2020
@emmanuelle
Copy link
Contributor

💃

@nicolaskruchten nicolaskruchten merged commit f8f202a into master Jun 25, 2020
@nicolaskruchten nicolaskruchten deleted the wide_line_group branch July 20, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelle emmanuelle Awaiting requested review from emmanuelle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.8.2
Development

Successfully merging this pull request may close these issues.

in wide-mode, px.line should set line_group="variable"
2 participants
@nicolaskruchten @emmanuelle