first and last color of cyclicals should match #2016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Without this fix:
With this fix:
|
|
Note that the last two look markedly better, and the other ones that changed don't look all that different, because the last color didn't change all that much. |
|
Looks good ! Ideally we would document the new cyclical swatches function but maybe it should go instead to a new "colors" page of the documentation (I think you mentioned it previously). Maybe open an issue to remember that we need to document this? But this should not block the PR, so 💃 |
|
I've just added this page in doc-prod https://plot.ly/python/builtin-colorscales/ so I'll update this PR to expand that page a bit :) |
Merged
nicolaskruchten
force-pushed
the
cyclical_fix
branch
from
811aea6 to
d886b2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.