Skip to content

Conversation

samhinshaw
Copy link
Contributor

@samhinshaw samhinshaw commented Dec 14, 2024

Backport of #7313 for plotly.js v2.

Fixes #7312.
@plotly/plotly_js

@samhinshaw samhinshaw requested review from archmoj and removed request for archmoj December 14, 2024 01:09
@archmoj archmoj marked this pull request as ready for review December 14, 2024 02:38
@archmoj
Copy link
Contributor

archmoj commented Dec 14, 2024

Thanks very much @samhinshaw for your help in catching the bug as well as this PR.
It was a great experience pair programming with you on this issue as well as on other upcoming PRs that we will merge into the master branch (as part of the v3 release).
FYI - I tested your proposed fix on CircleCI on top of the master branch and all the tests pass.
https://app.circleci.com/pipelines/github/plotly/plotly.js/11732/workflows/9e1ac8eb-ee34-48b3-a450-78e65818d1fd?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary

Therefore I move forward and merge this PR into the v2 branch, then release v2.35.3 patch to unblock the DE release.
Thank you!
And have a good weekend.

@archmoj archmoj merged commit 57a2214 into v2 Dec 14, 2024
1 check failed
@archmoj archmoj deleted the bugfix/backport-set-container-height branch December 14, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants