Handle recent changes to ggplot2's plot_build() logic
#2262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
commented
May 3, 2023
cpsievert
commented
May 3, 2023
cpsievert
commented
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2259
This PR add support for recent (internal) changes to ggplot2 (mostly the ones made in tidyverse/ggplot2#4879 and tidyverse/ggplot2#5144). These changes removed some internal ggplot2 functions
ggplotly()was using to translate to plotly.js. Fortunately, the relevant logic is still accessible via methods on the plot object, so going forwardggplotly()won't be as reliant on internal ggplot2 functions.