Skip to content

Conversation

willeastcott
Copy link
Contributor

No description provided.

@willeastcott willeastcott requested a review from Copilot September 3, 2025 13:58
@willeastcott willeastcott self-assigned this Sep 3, 2025
@willeastcott willeastcott added the enhancement New feature or request label Sep 3, 2025
@willeastcott willeastcott merged commit c735391 into main Sep 3, 2025
2 checks passed
@willeastcott willeastcott deleted the engine-session branch September 3, 2025 14:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates multiple HTML example files to use the xr-session.mjs script from the PlayCanvas engine's node_modules directory instead of a local copy, and removes the local implementation of the script.

  • Replaced local assets/scripts/xr-session.mjs references with engine version from ../node_modules/playcanvas/scripts/esm/xr-session.mjs
  • Removed the local xr-session.mjs file entirely
  • Cleaned up id attributes from some pc-asset elements in the text3d.html file

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
text3d.html Updated asset references and removed unnecessary id attributes
splat.html Changed xr-session script source to use engine version
shoe-configurator.html Changed xr-session script source to use engine version
positional-sound.html Changed xr-session script source to use engine version
physics.html Changed xr-session script source to use engine version
glb.html Changed xr-session script source to use engine version
car-configurator.html Changed xr-session script source to use engine version
basic-shapes.html Changed xr-session script source to use engine version
examples/assets/scripts/xr-session.mjs Removed local implementation of xr-session script
annotations.html Changed xr-session script source to use engine version
animation.html Changed xr-session script source to use engine version

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant