Skip to content

[Fix] Fix to morphing using incorrect shader when multiple morph meshes are used #7848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

[Fix] Fix to morphing using incorrect shader when multiple morph meshes are used #7848

merged 1 commit into from
Jul 22, 2025

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jul 22, 2025 •
edited
Loading

Fixes #7835

  • the unique morph shader name was not customized using defines, and so incorrect shader variant was used.

Separate change:

  • converted sampled texture reading to fetching, to improve performance, limit possible sampling issues.

@mvaligursky mvaligursky self-assigned this Jul 22, 2025
@mvaligursky mvaligursky added bug area: graphics Graphics related issue labels Jul 22, 2025
@mvaligursky mvaligursky requested a review from a team July 22, 2025 15:00
@mvaligursky mvaligursky merged commit 9c29919 into main Jul 22, 2025
7 checks passed
@mvaligursky mvaligursky deleted the mv-morphing-fix branch July 22, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Morph weight causing misaligned mesh after engine 2.8.0+
2 participants
@mvaligursky @slimbuck