Input source codes fixes #7842
Merged
Input source codes fixes #7842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions and improve button count handling
There was a problem hiding this comment.
Pull Request Overview
This PR fixes input source code handling by correcting the key count range and refactoring hardcoded constants to be derived from readonly constant definitions. The changes ensure that the CTRL key code is properly included in the count and improve maintainability by eliminating magic numbers.
- Fixed missing
CTRLkey in the key count calculation forKeyboardMouseSource - Refactored hardcoded array sizes to be derived from constant definitions
- Applied consistent pattern across both keyboard-mouse and gamepad input sources
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/extras/input/sources/keyboard-mouse-source.js | Moved key codes to top-level constant and derived KEY_COUNT from object length |
| src/extras/input/sources/gamepad-source.js | Moved button codes to top-level constant and replaced hardcoded array sizes with BUTTON_COUNT |
willeastcott
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeyboardMouseSourcekey codes (was missingCTRL)