Skip to content

screenToWorld & worldToScreen camera rect #7816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 3, 2025
Merged

screenToWorld & worldToScreen camera rect #7816

merged 4 commits into from
Jul 3, 2025

Conversation

kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Jul 2, 2025

Fixes #7815

Remaps the screen coordinates to the camera view rect coordinates in screenToWorld and worldToScreen

Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. I'd update the function description to mention the rect is applied.
Also, it'd be great to update worldToScreen the same way

@kpal81xd kpal81xd changed the title ScreenToWorld camera rect ScreenToWorld & worldToScreen camera rect Jul 3, 2025
@kpal81xd kpal81xd requested a review from mvaligursky July 3, 2025 10:10
@kpal81xd kpal81xd changed the title ScreenToWorld & worldToScreen camera rect screenToWorld & worldToScreen camera rect Jul 3, 2025
@kpal81xd kpal81xd merged commit 8d17377 into main Jul 3, 2025
7 checks passed
@kpal81xd kpal81xd deleted the camera-rect branch July 3, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

screenToWorld and worldToScreen ignores camera rect
3 participants