Skip to content

Fix shaderParticle assignment (#7787) #7788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged

Conversation

michaelfranzl
Copy link
Contributor

Fixes #7787

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted, thanks!

@mvaligursky mvaligursky merged commit d7ffbff into playcanvas:main Jun 19, 2025
7 checks passed
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the property used for the “stop” update shader in ParticleEmitter by renaming it to better reflect its purpose.

  • Rename shaderParticleUpdateNoRespawn to shaderParticleUpdateOnStop to match the ON_STOP define.
Comments suppressed due to low confidence (1)

src/scene/particle-system/particle-emitter.js:695

  • After renaming this property, update all references to shaderParticleUpdateNoRespawn elsewhere in the class or consuming code to shaderParticleUpdateOnStop to prevent undefined property errors at runtime.
        this.shaderParticleUpdateOnStop = ShaderUtils.createShader(gd, shaderOptions);

slimbuck pushed a commit that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue area: particles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo causes stopping particle systems to always throw TypeError
3 participants