Remove platform/audio #7774
Merged
Remove platform/audio #7774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the legacy Channel and Channel3d classes from platform/audio, migrates all remaining audio-related code into platform/sound, and updates imports and exports to reference the new sound location.
- Deleted outdated channel classes and playback methods
- Updated imports of constants and capabilities to
platform/sound - Adjusted top-level exports and framework audio handlers to use
soundpaths
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/platform/sound/manager.js | Removed Channel/Channel3d imports and deprecated playback methods |
| src/platform/sound/instance3d.js | Switched constants and capabilities imports to ./ |
| src/platform/sound/instance.js | Switched capabilities import to ./ |
| src/platform/audio/channel3d.js | Removed outdated 3D channel implementation |
| src/platform/audio/channel.js | Removed legacy channel implementation |
| src/index.js | Replaced audio exports with platform/sound exports |
| src/framework/handlers/audio.js | Updated hasAudioContext import to platform/sound |
| src/framework/components/sound/system.js | Updated hasAudioContext import to platform/sound |
| src/framework/components/sound/component.js | Updated DISTANCE_* import to platform/sound |
slimbuck
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ChannelandChannel3dclasses should have been removed along withAudioSourceComponent. This PR removes them and moves remaining code fromplatform/audiointoplatform/sound.I confirm I have read the contributing guidelines and signed the Contributor License Agreement.