Skip to content

Script Types & ESLint #7288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2025
Merged

Script Types & ESLint #7288

merged 2 commits into from
Jan 16, 2025

Conversation

kpal81xd
Copy link
Contributor

  • Adds eslint rule for ESM scripts to eslint config
  • Adds root types to re-export playcanvas types for ESM scripts to use correct typing

willeastcott
willeastcott approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But wondering if we could keep playcanvas.d.ts out of the root.

@kpal81xd
Copy link
Contributor Author

Looks good. But wondering if we could keep playcanvas.d.ts out of the root.

Yea unfortunately not since it exploits the fact that the 'playcanvas' import is actually a relative path with no extension and not a module

@kpal81xd kpal81xd self-assigned this Jan 16, 2025
@kpal81xd kpal81xd merged commit 6143472 into main Jan 16, 2025
7 checks passed
@kpal81xd kpal81xd deleted the scripts-types branch January 16, 2025 15:28
mvaligursky pushed a commit that referenced this pull request Jan 17, 2025
@kpal81xd
Fixed typing and eslint for ESM scripts (#7288)
82d9b96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@kpal81xd kpal81xd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpal81xd @willeastcott