Skip to content

[Fix] Handle CameraFrame script changing enabled state #7282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 15, 2025
Merged

[Fix] Handle CameraFrame script changing enabled state #7282

merged 2 commits into from
Jan 15, 2025
+9 −1

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jan 15, 2025 •
edited
Loading

  • handle enabled state to disable camera frame in the engine (deallocates some memory, but also swaps HDR to LDR rendering - gamma)
  • fix for drop down no longer working with an empty string '', using 'none' instead

@mvaligursky mvaligursky self-assigned this Jan 15, 2025
@mvaligursky mvaligursky requested a review from a team January 15, 2025 15:02
@mvaligursky mvaligursky added bug area: graphics Graphics related issue labels Jan 15, 2025
@mvaligursky mvaligursky merged commit 07c63a1 into main Jan 15, 2025
7 checks passed
@mvaligursky mvaligursky deleted the mv-camera-frame-gamma-fix branch January 15, 2025 15:11
mvaligursky added a commit that referenced this pull request Jan 17, 2025
@mvaligursky
[Fix] Handle CameraFrame script changing enabled state (#7282)
7a00ee5 
* [Fix] Handle CameraFrame script changing enabled state

* lint

---------

Co-authored-by: Martin Valigursky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @willeastcott