Skip to content

Gizmo rotation direction fix #7076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Gizmo rotation direction fix #7076

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2cbb89
Fixed gizmo rotation issue at large distances
kpal81xd Oct 29, 2024
ada695a
Removed line draw
kpal81xd Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/extras/gizmo/rotate-gizmo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ import { TransformGizmo } from './transform-gizmo.js';
// temporary variables
const tmpV1 = new Vec3();
const tmpV2 = new Vec3();
const tmpV3 = new Vec3();
const tmpV4 = new Vec3();
const tmpM1 = new Mat4();
const tmpQ1 = new Quat();
const tmpQ2 = new Quat();
Expand Down Expand Up @@ -480,10 +482,11 @@ class RotateGizmo extends TransformGizmo {
angle = Math.sign(facingDot) * Math.atan2(tmpV1.y, tmpV1.x) * math.RAD_TO_DEG;
} else {
// convert rotation axis to screen space
tmpV2.cross(plane.normal, facingDir).normalize();
this._camera.worldToScreen(tmpV1.copy(gizmoPos), tmpV1);
this._camera.worldToScreen(tmpV2.add(gizmoPos), tmpV2);
tmpV1.sub2(tmpV2, tmpV1).normalize();
tmpV1.copy(gizmoPos);
tmpV2.cross(plane.normal, facingDir).normalize().add(gizmoPos);
this._camera.worldToScreen(tmpV1, tmpV3);
this._camera.worldToScreen(tmpV2, tmpV4);
tmpV1.sub2(tmpV4, tmpV3).normalize();
tmpV2.set(x, y, 0);
angle = tmpV1.dot(tmpV2);
}
Expand Down