Implement ACL APIs #150
Merged
Implement ACL APIs #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lp247
force-pushed
the
admin_acls
branch
2 times, most recently
from
7153c11 to
250de4f
Compare
mcollina
reviewed
Nov 8, 2025
| @@ -1,4 +1,5 @@ | |||
| Copyright 2025 Platformatic | |||
| Copyright 2025 SAP SE or an SAP affiliate company. All rights reserved. | |||
ShogunPanda
reviewed
Nov 10, 2025
Contributor
ShogunPanda
left a comment
ShogunPanda
left a comment
There was a problem hiding this comment.
LGTM minus the NOTICE file change.
This change implements createAcls, describeAcls, and deleteAcls on the admin client.
Member
|
I'm sorry I made a mistake and landed with the attribution. We cannot accept that change. I've reverted the commit. Please send a again the PR without that attribution. |
Member
|
(I've actually rebased out the commit, sorry) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements
createAcls,describeAcls, anddeleteAclson the admin client.Note: As I am contributing this PR (and others) on behalf of SAP, I added a contribution attribution for SAP in this PR. As I could not find any specific guidelines for that, I have added it to the NOTICE file in the root directory. Please let me know if you have any issues with that.