Add string utf-8 validation #161
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
If we did introduce this, it would have to be done as a flag to opt into this behavior since it's a breaking change. Even tho it's more correct, people (including us unfortunately) depend on this incorrect behavior. This originally came from the gogoproto implementation which also did not validate for UTF-8 strings. But as is, this absolutely would break Vitess. |
Author
|
Thank you for the review! I added generator option to keep the current behavior. |
Author
|
@mattrobenolt |
Author
|
@mattrobenolt |
Author
|
@mattrobenolt @vmg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #146
Adding string utf-8 validation.
This change makes vtprotobuf to align the other protobuf implementations.(e.g. protobuf-go, protobuf-cpp, etc)