Revert generator functions name change and update usage #814
Conversation
|
@JuLeeAtPlanet FYI docs change |
| download_filter = filters.permission_filter() | ||
| search_results = await client.search(["PSScene"], filters.and_filter([date_filter, cloud_filter, download_filter])) | ||
| return [item async for item in search_results] | ||
| return [item async for item in client.search(["PSScene"], filters.and_filter([date_filter, cloud_filter, download_filter]))] |
There was a problem hiding this comment.
What was purpose of shoving these two lines into a one-liner? I tend to find these code compressions confusing to read in retrospect and more difficult to maintain.
There was a problem hiding this comment.
@kevinlacaille you've got a valid point. The state of the art for usage is
async for item in client.search(...):
# do stuffAnd this can also be turned into a list comprehension like [item async for item in client.search(...)].
The code on line 52 could be made easier to read if the filter construction were lifted out, maybe? Like
search_filters = filters.and_filter([date_filter, cloud_filter, download_filter])
async for item in client.search(["PSScene"], search_filters):
# do stuffThere was a problem hiding this comment.
This certainly isn't worth re-opening this ticket for, but I do agree what @sgillies wrote would be easier to read and maintain in the future 👍
Related Issue(s):
Closes #813
Proposed Changes:
For inclusion in changelog (if applicable):
_aiter- aka, delete that from the changelogNot intended for changelog:
Diff of User Interface
Old behavior:
New behavior:
PR Checklist:
(Optional) @mentions for Notifications: