Skip to content

Conversation

@charcey
Copy link
Contributor

@charcey charcey commented Jan 16, 2025

Related Issue(s):
N/A

Closes #
N/A

Proposed Changes:

For inclusion in changelog (if applicable):

  1. SDK supports GEE delivery for Subscriptions
  2. SDK supports OCS delivery for Orders
  3. PS2 target sensor removed from harmonize tool (already not supported in the API)

Not intended for changelog:

  1. Added tests for new deliveries, added tests for recently added composite tool group by parameter, fixed some typos

Diff of User Interface

Old behavior:

  1. Couldn't create a subscription with gee delivery
  2. Couldn't create an order with ocs delivery
  3. Couldn't create an order or sub with harmonize tool using PS2 target sensor (would always fail as it is unsupported in both APIs)

New behavior:

  1. Can create a subscription with gee delivery
  2. Can create an order with ocs delivery
  3. No option to use PS2 as target sensor for harmonize tool

PR Checklist:

  • This PR is as small and focused as possible
  • If this PR includes proposed changes for inclusion in the changelog, the title of this PR summarizes those changes and is ready for inclusion in the Changelog.
  • I have updated docstrings for function changes and docs in the 'docs' folder for user interface / behavior changes
  • This PR does not break any examples or I have updated them

(Optional) @mentions for Notifications:

@charcey charcey changed the title Add GEE delivery option for Subscription, OCS delivery option for Orders, remove PS2 target sensor for harmonize tool Housekeeping: Add GEE delivery option for Subscription, OCS delivery option for Orders, remove PS2 target sensor for harmonize tool Jan 16, 2025
Copy link
Contributor

@asonnenschein asonnenschein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@charcey charcey merged commit c29856c into main Jan 16, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants