Don't depend on [!Default; 0]: Default impl
#201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NB: in `&[]` the array is "const promoted", making this reference have
type `&'static [T; 0]`. this allows us to return that reference from
any function returning a reference to a slice or array, because
`&'static _` can coerce to `&'short_lifetime _`.
it's not necessary to have a field for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are plans to remove the unconditional
[T; 0]: Defaultimpl (whereTdoesn't necessarily implementDefault) from the standard library (see rust-lang/rust#145457). That is a breaking change that would affect this crate.This PR fixes this by removing a dependency on that impl.
See commit description for why this works.