Fix runtime log level changes #16
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
The
consoleandstreamhandlers currently do not respect runtime logger instance-level log level configuration changes as they store the instance-level log level which was set when they were initialized.Why are we doing this?
To permit dynamic log level changes to work as documented: https://github.com/piotrmurach/tty-logger/blob/master/README.md#24-configuration
Benefits
Drawbacks
I did not measure it, but this change likely results in a small performance hit as there is some additional logic run for every log message.
Requirements
masterbranch?