Skip to content

Add missing methods that generate mocks #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2017
Merged

Add missing methods that generate mocks #2

merged 1 commit into from
Dec 11, 2017

Conversation

lcobucci
Copy link
Contributor

Some methods were missing, and when used phpstan doesn't work properly. It shows errors like:

Property MyTest::$property (MockedClass&PHPUnit\Framework\MockObject\MockObject) does not accept PHPUnit\Framework\MockObject\MockObject.

This PR fixes it, but I didn't add any test (since the repo doesn't have any)

@lcobucci
Add missing methods that generate mocks
e834adb 
- `createPartialMock()` is available since PHPUnit 5.5.0
- `createTestProxy()` is available since PHPUnit 6.0.0
@ondrejmirtes
Copy link
Member

Thank you! 👍

@ondrejmirtes ondrejmirtes merged commit 96d2421 into phpstan:master Dec 11, 2017
@lcobucci lcobucci deleted the add-missing-methods branch December 11, 2017 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lcobucci @ondrejmirtes