Skip to content

Mark nullable EntityRepository methods as impure #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged

Mark nullable EntityRepository methods as impure #648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions stubs/EntityRepository.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ class EntityRepository implements ObjectRepository
* @phpstan-param int|null $lockMode
* @phpstan-param int|null $lockVersion
* @phpstan-return TEntityClass|null
* @phpstan-impure
*/
public function find($id, $lockMode = null, $lockVersion = null);

Expand All @@ -41,6 +42,7 @@ class EntityRepository implements ObjectRepository
* @phpstan-param array<string, mixed> $criteria The criteria.
* @phpstan-param array<string, string>|null $orderBy
* @phpstan-return TEntityClass|null
* @phpstan-impure
*/
public function findOneBy(array $criteria, ?array $orderBy = null);

Expand Down
Loading