Deprecate disabling report_memleaks INI directive
#19481
+32
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
report-memleaks-deprec
branch
2 times, most recently
from
70f33af to
d6fdf2f
Compare
bukka
requested changes
Aug 14, 2025
alexandre-daubois
force-pushed
the
report-memleaks-deprec
branch
from
d6fdf2f to
6b546c7
Compare
alexandre-daubois
changed the title
report_memleaks INI directivereport_memleaks INI directive
TimWolla
reviewed
Aug 14, 2025
php.ini-development
Outdated
| @@ -537,6 +537,7 @@ ignore_repeated_errors = Off | |||
| ; https://php.net/ignore-repeated-source | |||
| ignore_repeated_source = Off | |||
|
|
|||
| ; DEPRECATED: This INI setting is deprecated and will be removed in PHP 9.0. | |||
There was a problem hiding this comment.
This formatting is inconsistent with the other deprecated options, please unify.
I also wonder if there still is value in having this option readily presented in the example INI files. It's deprecated and only affects a debug build. Perhaps we can just remove this entire block for improved DX? If we want to keep it, the INI should be commented, though (to make sure it uses the built-in default).
There was a problem hiding this comment.
I'd say it should be kept. It costs nothing and this will avoid making exceptions for certain settings. Maybe it could also be easier for maintainers when upmerging.
alexandre-daubois
force-pushed
the
report-memleaks-deprec
branch
from
6b546c7 to
9a42d86
Compare
TimWolla
reviewed
Aug 14, 2025
alexandre-daubois
force-pushed
the
report-memleaks-deprec
branch
from
9a42d86 to
e3f4fef
Compare
DanielEScherzer
requested changes
Aug 14, 2025
16 tasks
alexandre-daubois
force-pushed
the
report-memleaks-deprec
branch
from
e3f4fef to
6313179
Compare
alexandre-daubois
force-pushed
the
report-memleaks-deprec
branch
from
6313179 to
a3b1595
Compare
Girgias
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_the_report_memleaks_ini_directive