-
Notifications
You must be signed in to change notification settings - Fork 7.9k
docs: add macos instruction, update blocks #18670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
approved these changes
May 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit but MSTM
Co-authored-by: Gina Peter Banyard <[email protected]>
Windows does not use make. It doesn't make sense to mention a single Windows step, as building on Windows is much more complicated.
Thanks @xepozz! |
Krinkle
added a commit
to Krinkle/php-src
that referenced
this pull request
Aug 14, 2025
Follows-up 22e444c (phpGH-18670). There is currently no formula called "iconv" at https://brew.sh/ or https://github.com/Homebrew/homebrew-core/. ``` $ brew install iconv Warning: No available formula with the name "iconv". Did you mean icon or cconv? ``` There is one called libiconv, however. https://formulae.brew.sh/formula/libiconv
Krinkle
added a commit
to Krinkle/php-src
that referenced
this pull request
Aug 15, 2025
Follows-up 22e444c (phpGH-18670). There is currently no formula called "iconv". [1][2] ``` $ brew install iconv Warning: No available formula with the name "iconv". Did you mean icon or cconv? ``` There package is called "libiconv". [3] Once installed, `./configure` still fails due to a discovery issue. ``` $ ./configure --enable-debug … checking for libiconv... no configure: error: Please specify the install prefix of iconv with --with-iconv=<DIR> ``` In 2020, as part of the switch from Intel to ARM, Homebrew adopted /opt as the standard location instead of /usr/local. [4][5] Rather than complicating the README with a mandatory `--with-iconv` path (or --without-iconv) for macOS users, improve the discovery to support Homebrew's new location. Place it after /usr/local, so that /usr/local remains the preferred place for system overrides (in case both are present). Place it before /usr, because there may be older system versions of these packages on macOS that would otherwise have precedence, making it impossible to satisfy version requirements. [1]: https://brew.sh/ [2]: https://github.com/Homebrew/homebrew-core/. [3]: https://formulae.brew.sh/formula/libiconv [4]: https://apple.stackexchange.com/a/437622/33762 [5]: https://docs.brew.sh/FAQ#why-is-the-default-installation-prefix-opthomebrew-on-apple-silicon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.