Synchronize manual with stubs for PHP 8.4 - part 2 #4178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
requested changes
Nov 28, 2024
Comment on lines
55
to
57
| <para> | ||
| Returns a new <classname>DateInterval</classname> instance on success, &return.falseforfailure;. | ||
| Returns a new <classname>DateInterval</classname> instance. | ||
| </para> |
There was a problem hiding this comment.
There is an entity IIRC for procedural return false for failure, which needs to be used.
There was a problem hiding this comment.
Yes, I found it at last
Comment on lines
44
to
46
| <para> | ||
| &date.datetime.return.modifiedobjectorfalseforfailure; | ||
| &date.datetime.return.modifiedobject; | ||
| </para> |
There was a problem hiding this comment.
Ditto procedurally, this still returns false.
Comment on lines
30
to
31
| &return.true.always; As with all functionality that modifies the contents of | ||
| a phar, the <link linkend="ini.phar.readonly">phar.readonly</link> INI variable |
There was a problem hiding this comment.
Suggested change
| &return.true.always; As with all functionality that modifies the contents of | |
| a phar, the <link linkend="ini.phar.readonly">phar.readonly</link> INI variable | |
| &return.true.always; | |
| As with all functionality that modifies the contents of | |
| a phar, the <link linkend="ini.phar.readonly">phar.readonly</link> INI variable |
kamil-tekiela
approved these changes
Nov 28, 2024
Girgias
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, all the affected mysqli and Phar methods were always returning
true.