Skip to content

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Nov 11, 2024

Waiting on php/php-src#16751

@Girgias Girgias added this to the PHP 8.4 milestone Nov 11, 2024
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits, but basically looks good. Thank you!

<member><function>pow</function></member>
<member><function>fdiv</function></member>
<member><function>fmod</function></member>
<!-- TODO ** operator link?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe. On the other hand, we already link to pow what might be good enough.

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Girgias Girgias merged commit 2b7eeba into php:master Nov 12, 2024
2 checks passed
@Girgias Girgias deleted the fpow branch November 12, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants