Skip to content

Documentation for pcntl_waitid #3518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 22, 2024
Merged

Documentation for pcntl_waitid #3518

merged 12 commits into from
Sep 22, 2024

Conversation

vrza
Copy link
Contributor

@vrza vrza commented Jul 1, 2024 •
edited
Loading

Related php-src issue

Related php-src PR

Related php-src commit

  • documented new function pcntl_waitid
  • documented related constants
  • added missing documentation for pcntl_get_last_error and pcntl_strerror

@vrza vrza changed the title Added function pcntl_waitid Documentation for pcntl_waitid Jul 1, 2024
@vrza vrza mentioned this pull request Jul 1, 2024
Closed
@devnexen
Copy link
Member

devnexen commented Jul 7, 2024

look good/complete overall, the build failures look legit. Anyhow, preferably someone more "senior" will double-check :)

@devnexen devnexen requested a review from Girgias July 7, 2024 10:24
@vrza vrza mentioned this pull request Jul 20, 2024
Closed
Girgias
Girgias requested changes Aug 25, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't go through each instance of an issue but every comment should highlight the issues that currently exist.

Girgias
Girgias requested changes Sep 11, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plenty of review comments still have not been addressed.

@vrza vrza mentioned this pull request Sep 16, 2024
Closed
@vrza vrza requested a review from Girgias September 16, 2024 23:19
Girgias
Girgias requested changes Sep 17, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about the wording as I don't know the behaviour but some markup questions

Girgias
Girgias approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Girgias Girgias merged commit 4ac5624 into php:master Sep 22, 2024
2 checks passed
@jdkfx jdkfx mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vrza @devnexen @Girgias