docs: remove $ in bash command #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With the removed |
|
looks good right? the phpstan errors are probably because of improved phpstan, and we seem to miss the configuration that it should not treat phpdoc as guaranteed. |
|
Yes. phpstan is not related to this PR.Could be fixed in a seperate PR.Am 16.02.2025 um 17:09 schrieb David Buchmann ***@***.***>:
looks good right?
the phpstan errors are probably because of improved phpstan, and we seem to miss the configuration that it should not treat phpdoc as guaranteed.—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
dbu left a comment (php-http/message#167)
looks good right?
the phpstan errors are probably because of improved phpstan, and we seem to miss the configuration that it should not treat phpdoc as guaranteed.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
yeah phpstan is not related. i checked the normalize output and saw no deprecation warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test for #166