Skip to content

Add errata detailing addition of scalar type hints for PSR-11 (ContainerInterface) #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2021
Merged

Add errata detailing addition of scalar type hints for PSR-11 (ContainerInterface) #1215

merged 1 commit into from
Mar 5, 2021

Conversation

@weierophinney
Copy link
Contributor

@weierophinney weierophinney commented Jun 19, 2020

@weierophinney weierophinney requested a review from a team as a code owner June 19, 2020 13:05
Jean85
Jean85 reviewed Jun 19, 2020
View reviewed changes
Copy link
Member

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formally this change is ok.
As per our bylaw, it will be merged after a successful CC vote.

@weierophinney
Copy link
Contributor Author

weierophinney commented Jun 24, 2020

Ping @moufmouf — are you okay with this?

@dragoonis
Copy link
Member

dragoonis commented Jun 25, 2020

Looks decent 👍

@Jean85
Copy link
Member

Jean85 commented Jun 26, 2020

On hold until #1216 goes through.

This was referenced Jun 26, 2020
Merged
Merged
Jean85
Jean85 approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vote has passed.

@Jean85 Jean85 merged commit 1842113 into php-fig:master Mar 5, 2021
This was referenced Mar 8, 2021
Closed
Closed
Merged
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jean85 Jean85 Jean85 approved these changes

+1 more reviewer

@ashnazg ashnazg ashnazg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PSR-11: Container WIP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@weierophinney @dragoonis @Jean85 @ashnazg