Skip to content

Conversation

mahdilamb
Copy link

  • Use ducktyping for Generic Models
  • use model_config instead of Config attr

@bllchmbrs
Copy link

thanks for opening this, was helpful to me! Hope it gets merged soon !

@skaparis
Copy link

it would be great to process this PR

@pcorpet
Copy link

pcorpet commented Dec 26, 2023

@phillipdupuis Any chance you can take a look at this one please?

@voidus
Copy link

voidus commented Jan 12, 2024

What's the difference between this PR and #37 or #38 ?

Can they be consolidated?

@MatthewScholefield
Copy link

Btw should we close this now that #38 has been merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants