Fix UB in IntoOnes and setup testing with MIRI
#112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111
This also adds a Github Actions workflow for testing with MIRI. I reduced the size of some tests when ran with MIRI because they were taking a lot of time on my PC (the reduced version runs in 1 minute and 20 seconds on CI, which I considered to be acceptable, let me know if they should be reduced even further).
While I was there I also removed some parameters that the
rust-toolchainaction ignores (see for example this warning https://github.com/petgraph/fixedbitset/actions/runs/8339136052/job/22820592988#step:3:1)