Added support for full set of marked options. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jhnns please review, merge and publish this PR CC: @matthaias @meaku @sbat @topa or some one from this team:) |
|
Looks good! Thank you! |
meaku
added a commit
that referenced
this pull request
Sep 4, 2015
Added support for full set of marked options.
|
@meaku will you be able to publish this changes? please :) |
|
Released as 0.1.7. |
|
Thank you so much) |
|
No worries! I just had to try the whole thing, because i'm not into webpack as deeply as @jhnns ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
Great job in the markdown loader. I'm trying to use more options from marked module: highlight attribute which expects a function (similar to the renderer). I was unable to send such a function as a query param.
This PR aims to extend the functionality already in place for renderer function. With my changes, all regular marked options are accepted inside
markdownLoaderobject.Alan